Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querying for falsy values through @whereConstraints #800

Merged
merged 7 commits into from
May 21, 2019

Conversation

abibby
Copy link
Contributor

@abibby abibby commented May 21, 2019

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated the changelog

Related Issue/Intent

Resolves #799

Changes

Searching for an empty string using where constraints use to cause an error, it now searches for an empty string

Breaking changes

If someone was counting on searching for an empty string returning an error it will no longer do that

@spawnia spawnia changed the title Fix where constraints on empty string Fix querying for falsy values through @whereConstraints May 21, 2019
@spawnia spawnia added the bug An error within Lighthouse label May 21, 2019
@spawnia spawnia merged commit db4e1d4 into nuwave:master May 21, 2019
@spawnia
Copy link
Collaborator

spawnia commented May 21, 2019

Thanks @zwzn for the bug report & the quick PR. Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error within Lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to search by empty string on where constraints
2 participants