Populating nested mutations with other relationships for @update

[liepaja]

• Added or updated tests
• Added Docs for all relevant versions

Related Issue

Resolves #396
Resolves #583
Resolves #586

Related to #332

Changes

Adding other relationship capabilities to nested mutations when using @update.

| T indicates presence of a test

------------------------------- One to one/many

• BelongsTo

• create T

• update T

• delete T

• connect T

• disconnect T

• HasOne

• create T

• update T

• delete T

• HasMany

• create T

• update T

• delete T

------------------------------- Many to many

• BelongsToMany
• create T
• update T
• delete T
• connect T
• disconnect T
• sync T

------------------------------- Morph one to one/many

• MorphOne

• create T

• update T

• delete T

• connect

• MorphMany

• create T

• update T

• delete T

• connect

• MorphTo

• no args

[spawnia]

Hey, can you please check the changes that are up and coming in #518 ?

Would be nice if you can base your WIP on that, since otherwise it will require another rework afterwards. Thanks

[liepaja]

@spawnia it look like a huge PR, can you point to exactly what you mean? Do you mean the return types?

[spawnia]

Take a look at the MutationExecutor and the relevant tests for it.

[spawnia]

Hey, i noticed i did not have the changes that i referred to pushed. Sorry for the confusion, you can take a look now.

[liepaja]

Ok, so basically the style

[spawnia]

@liepaja can you give me a quick update on your progress with this? A use-case has popped up in our project that requires nested BelongsToMany updates.

[liepaja]

@spawnia sorry for late reply. I became quite busy recently. I plan to finish this PR by next weekends.

[spawnia]

As this has pretty high priority for us, i started working on your branch. Just merged in master, will start adding tests and implementations soon.

[lukadriel7]

Hello, thank you for the great work. How is it going?

[liepaja]

Ok, i am back on track, will try to finish it today.

[liepaja]

Core functionalities are added, will add tests and it can be merged

[TheJoeSchr]

that's really exciting to read, thanks!

[lukadriel7]

頑張れー

[liepaja]

@JoeSchr lets leave it for another pull request, i'll try to make tests today or tomorrow so this could be finally pushed.

[spawnia]

@liepaja great progress on this, keep it up :)

[TheJoeSchr]

@JoeSchr lets leave it for another pull request, i'll try to make tests today or tomorrow so this could be finally pushed.

Hi @liepaja, great work so far, but I actually think that at least detach is quite essential to have, otherwise you could never uncouple a many2many relationship.
But you will probably see that once you write the tests for it, I also needed to use it first to get that something is missing.

[spawnia]

Just a quick headsup @liepaja we are probably finishing this up by tomorrow hopefully in the next week 😓 .

[spawnia]

@liepaja @chrissm79 this should be ready, can you give it a quick review?

[chrissm79]

Fantastic work on this one @liepaja @spawnia, glad to get this one merged in!!

[liepaja]

@liepaja @chrissm79 this should be ready, can you give it a quick review?

Hey guys, sorry that couldn't properly finish PR. Got a tone of projects started, even a new youtube series :D.

[TheJoeSchr]

Hi,
I just tried to implement this new features for real in my project. I encounter a roadblock with a belongsToMany relationship, which has a pivot table (originally I'm using withPivot(...)->as('betterName'), but for the sake of debugging I left that one out):

class Patient extends Model
{
    // many to many RELATIONSHIPS
    public function medications(): BelongsToMany
    {
        return $this->belongsToMany(Medication::class, 'patients__medications', 'patient_id', 'medication_id')->withPivot('dose_mg', 'is_rescue_medication'); //->as("details");
    }
}

#schema.graphql excerpts
# Mutations {}
updateMedication(input: MedicationInput): Medication! @update(flatten: true)

# Types
# -- Medication
input MedicationInput {
    id: ID
    name: String
    pivot: MedicationDetailsInput
}

input MedicationDetailsInput {
    patient_id: ID
    medication_id: ID
    dose_mg: Float
    is_rescue_medication: Boolean
}
input MedicationRelation {
  update: [MedicationInput]
  connect: [MedicationDetailsInput]
  disconnect: [ID]
  create: [MedicationInput]
  delete: [MedicationInput]
  sync: [MedicationDetailsInput]
}

the error message I get is:

this seems to be the line where things are going wrong, since pivot property (and other name defined with as()) is not treated as special case:

sadly I don't know where to go from here, how I could resolve if there is a pivot defined, before passing it on into $remaining. and further how to than flatten/save it so laravel knows what to do with the pivot property.

but let me know if I can help you somehow to fix this.

[spawnia]

@JoeSchr there is nothing in Lighthouse right now that allows saving data to a pivot table directly through a nested BelongsToMany mutation.

You can treat your BelongsTo relation simply as two BelongsTo relationships to work around this.

If you want two allow changing pivot data as part of nested mutations, feel free to open up a new feature proposal/ PR. I am open for working that in, but the details for how the API might look are unclear to me.

[TheJoeSchr]

@spawnia Thanks, I worked some more on this and I think I'm almost there...

I had two problems, one I fixed, but in a hacky way ($accessor which has the name of the pivot property, is protected) and the other (how to save the pivot property with the model relation we already have) I'm still working on.

[TheJoeSchr]

are there any guide(-lines) for creating a PR? I have never done it before...

[TheJoeSchr]

ok, I got it working, I will try to make a PR tomorrow

[spawnia]

@JoeSchr https://github.com/nuwave/lighthouse/blob/master/.github/CONTRIBUTING.md

It is fine if you provide a WIP at first if the API is not fixed yet, but before merging anything we require tests and docs.

[TheJoeSchr]

Thanks, once I started looking for it, it was pretty easy to find and follow ;)

…

On Wed, Mar 27, 2019 at 9:15 PM Benedikt Franke ***@***.***> wrote: @JoeSchr <https://github.com/JoeSchr> https://github.com/nuwave/lighthouse/blob/master/.github/CONTRIBUTING.md — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#549 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH1pHnE9Gukng7S0OvinNflsI1OUuJUoks5va9FUgaJpZM4Zw2Lb> .

[TheJoeSchr]

done: #692