Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to set injected value with dot notation deeper #511

Merged
merged 6 commits into from
Dec 16, 2018

Conversation

liepaja
Copy link
Contributor

@liepaja liepaja commented Dec 16, 2018

  • Added or updated tests
  • Added Docs for all relevant versions

Related Issue/Intent

Allows inject with dot notation. For example if using input object. This allows to do as follows:
type Mutation { createPost($input: CreateObjectInput!): Post @create @inject(context: "user.id", name: "input.user_id") }

@spawnia
Copy link
Collaborator

spawnia commented Dec 16, 2018

Can you please add a test and update the docs on that?

@liepaja
Copy link
Contributor Author

liepaja commented Dec 16, 2018

I don't see mutations in the tests, any guidelines for that?

@spawnia
Copy link
Collaborator

spawnia commented Dec 16, 2018

I suggest you add a test case to InjectDirectiveTest, you can look at something like the CreateDirectiveTest to see how mutations are set up there.

@spawnia
Copy link
Collaborator

spawnia commented Dec 16, 2018

@liepaja good work, thanks!

@spawnia spawnia merged commit c5707ae into nuwave:master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants