Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Date to startOfDay #452

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Set Date to startOfDay #452

merged 1 commit into from
Nov 30, 2018

Conversation

sp3259
Copy link
Contributor

@sp3259 sp3259 commented Nov 30, 2018

  • Added or updated tests

Related Issue/Intent

Set date to startofDay otherwise Date is set date + current timestamp and fails equality checks with existing dates

Breaking changes

No

spawnia
spawnia approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spawnia spawnia merged commit 4c3b176 into nuwave:master Nov 30, 2018
@spawnia spawnia deleted the setDatetoStartOfDay branch November 30, 2018 12:38
@spawnia
Copy link
Collaborator

spawnia commented Nov 30, 2018

Thanks @sp3259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spawnia spawnia spawnia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sp3259 @spawnia