DO-NOT-MERGE Rework how AST nodes are converted into the executable schema #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #184 There is now a clean seperation between FieldDefinitions and InputObjectValues. They were previously muddled together, which caused our type annotations to be unnecessarily loose and required some workarounds. As a result, the way the Field|Node|Arg-Value objects are constructed were changed and compatibility with the previous ValueFactory can not be guaranteed. I cleaned up some unneeded methods in the Value objects to streamline their behaviour.
Merged
|
@chrissm79 This PR is meant just for ease of review. It contains a single failing test, which will pass once we remove the #427 contains the entire set of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184
There is now a clean seperation between FieldDefinitions and InputObjectValues.
They were previously muddled together, which caused our type annotations to be
unnecessarily loose and required some workarounds.
Breaking changes
The way the Field|Node|Arg-Value objects are
constructed were changed and compatibility with the previous ValueFactory can not be guaranteed.
I cleaned up some unneeded methods in the Value objects to streamline their behaviour.