Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cacheable schema manipulation via directives #140

Merged
merged 79 commits into from
Jun 20, 2018
Merged
Changes from 1 commit
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
5d3bdd8
Create common interface for all directives to force them to have a name
spawnia May 29, 2018
4955642
Convert name to static method and use it where applicable, improve ty…
spawnia May 30, 2018
db134ac
WIP
spawnia May 30, 2018
f9b3128
Use spawnia/php7.1-fpm for running tests locally
May 30, 2018
7b46276
Create common interface for all directives to force them to have a name
spawnia May 29, 2018
428d766
Convert name to static method and use it where applicable, improve ty…
spawnia May 30, 2018
c9514f9
WIP
spawnia May 30, 2018
63b86b3
WIP
spawnia Jun 6, 2018
cef89e2
Merge remote-tracking branch 'origin/generator-directives' into gener…
spawnia Jun 7, 2018
8fffa48
Resolve merge conflicts by latest master updates
spawnia Jun 7, 2018
cc92ff3
Apply field middleware before building the resolver, rename SchemaGen…
spawnia Jun 7, 2018
9a1814e
Move directive interfaces to their respective folders. Create seperat…
spawnia Jun 7, 2018
292a48d
Add in ArgManipulator and apply it as well
spawnia Jun 7, 2018
8500d48
Move interface registration into SchemaManipulation
spawnia Jun 7, 2018
13ac5e7
Fix type definition in NodeValue, remove unused code
spawnia Jun 7, 2018
c09f94b
Only load instantiable directives from Directives folder
spawnia Jun 7, 2018
85347d0
Remove unused method and use native Parser method instead
spawnia Jun 7, 2018
d8ed145
Simplify CreatePaginator and move it to Directives Folder
spawnia Jun 7, 2018
f99fe5a
Cache the complete AST
spawnia Jun 7, 2018
264de32
Run php-cs-fixer
spawnia Jun 7, 2018
f4768dc
Move injection of the node type + query field into ASTBuilder
spawnia Jun 7, 2018
7b5364c
Only cache in production and when cache.enabled is true
spawnia Jun 7, 2018
71c5685
Reenable Macros, were removed by accident
spawnia Jun 7, 2018
32bd88d
Cleanup and style fixes
spawnia Jun 7, 2018
9a39961
WIP
spawnia May 30, 2018
34cac6c
Add method for retrieving fragments from document
spawnia Jun 7, 2018
c3cb720
Fix some terribly misguided attempt at merging
spawnia Jun 7, 2018
ff23e32
Merge remote-tracking branch 'origin/generator-directives' into gener…
spawnia Jun 7, 2018
e77dcc2
Merge
spawnia Jun 7, 2018
be5b920
Remove duplicate class
spawnia Jun 8, 2018
0234b15
Rename DirectiveFactory to DirectiveRegistry and clean up functionality
spawnia Jun 8, 2018
44e86cb
Clear up semantics around NodeResolvers: Rename to TypeResolver, expl…
spawnia Jun 8, 2018
feb8a12
Split up Types and Directives cleanly
spawnia Jun 8, 2018
5a47cb0
Style fixes
spawnia Jun 8, 2018
baa1737
Update docs
spawnia Jun 8, 2018
ee4e1ac
Expand group directive test
spawnia Jun 8, 2018
9d10df4
Style fixes
spawnia Jun 8, 2018
f3f6a13
Rename MiddlewareManager to MiddlewareRegistry
spawnia Jun 8, 2018
71ae394
Rename Node... test to Type...
spawnia Jun 8, 2018
67dca15
Break out type registry into singleton. Ensure field middlewares are …
spawnia Jun 8, 2018
4f24606
Add command for printing the final generated schema
spawnia Jun 8, 2018
05a9721
Merge branch 'generator-directives' of github.com:spawnia/lighthouse …
Jun 8, 2018
ba9907d
Test & Fix merging of multiple type extension fields
Jun 8, 2018
0c492b4
Move SchemaStitcherTest out of Utils Folder to AST Folder
Jun 8, 2018
bcbb493
WIP move PartialParser into seperate class and test parser methods
Jun 10, 2018
c4fef1a
Add in Helper class to fix inconsistencies of webonyx/graphql-php
spawnia Jun 11, 2018
50edb32
Add hint to issue https://github.com/webonyx/graphql-php/issues/285 w…
spawnia Jun 11, 2018
c95fab8
Add option for printing the schema to a file
spawnia Jun 11, 2018
e2bee2f
Add tests for DirectiveFactory, fix bug where no default value is pro…
Jun 11, 2018
e3c4e8c
Use config option for setting the cache key
spawnia Jun 12, 2018
a728eef
Cleanup & Compatibility fixes
spawnia Jun 12, 2018
1a005ae
Treat pagination type 'relay' as an alias for 'connection', use const…
spawnia Jun 12, 2018
e3d4592
Add in a backwards compatible but more flexible way of applying names…
spawnia Jun 13, 2018
b1c0730
Ensure backwards compatibility of AbstractFieldDirective, add test sh…
spawnia Jun 14, 2018
daa05a1
Consistently name PartialParser methods (Its the name of the class it…
spawnia Jun 14, 2018
6febde4
Rename HandleQueries to HandlesQueries for consistency with the other…
spawnia Jun 14, 2018
425d643
Clear up variable naming
spawnia Jun 14, 2018
d4c73bb
Simplify composer scripts and remove deprecated phpunit config option
spawnia Jun 14, 2018
54f9d1e
Remove leftover scrap file
spawnia Jun 14, 2018
735faa2
Split up Testsuites for Unit/Integration testing
spawnia Jun 14, 2018
e89a32e
Use the main GraphQL execute function for tests
spawnia Jun 14, 2018
b14e634
Use PartialParser to simplify tests
spawnia Jun 14, 2018
1257545
Test code refactoring & reformatting
spawnia Jun 14, 2018
7c91553
Fix phpunit configuration to prevent errors
spawnia Jun 14, 2018
d0a13c4
Switch test database to using actual utf8 (called utf8mb4 in MySQL)
spawnia Jun 15, 2018
b957b77
revert structural changes
chrissm79 Jun 17, 2018
81e2547
remove cache manager
chrissm79 Jun 17, 2018
bc05dd1
add refactoring
chrissm79 Jun 18, 2018
414838d
update tests
chrissm79 Jun 19, 2018
7aaa859
Merge pull request #1 from spawnia/schema-manipulation
spawnia Jun 19, 2018
18f3477
Remove docker-compose file as it is added in #139
Jun 19, 2018
1c881c7
Remove old import for base directive interface
Jun 19, 2018
4741bfe
Fix directives() helper return type
Jun 19, 2018
92fb3ec
Remove reference to CacheManager
Jun 19, 2018
01fac57
Add import for DocumentAST
Jun 19, 2018
1099d4a
Removed unused and deprecated imports
Jun 19, 2018
b67a665
Instantiate NodeFactory directly to get rid of type warning and impro…
Jun 19, 2018
82f7bee
Actually return an array of ValidatorMessages
Jun 19, 2018
9119e03
Fix PHPDocs
Jun 19, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually return an array of ValidatorMessages
  • Loading branch information
spawnia committed Jun 19, 2018
commit 82f7beef3fa8a9ea4251587d204901e93e737ab0
2 changes: 1 addition & 1 deletion src/Support/Exceptions/ValidationError.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ public function setValidator($validator)
*/
public function getValidatorMessages()
{
return $this->validator ? $this->validator->messages() : [];
return $this->validator ? $this->validator->messages()->all() : [];
}
}