-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested create, upsert and update on lists of inputs #1316
Fix nested create, upsert and update on lists of inputs #1316
Conversation
# Conflicts: # tests/Integration/Console/IdeHelperCommandTest.php
@megawubs the branch was quite out of date. There is a GitHub bot which automatically keeps your forks up to date: https://probot.github.io/apps/pull/ (Beware that it nukes any changes you made on the |
…-input' into fix-create-upsert-update-list-of-input # Conflicts: # CHANGELOG.md
Concerning 26a9406, we can not change that until we drop support for PHPUnit 6. |
@spawnia does this need an update on the docs? |
Did you already revert it? |
We actually have an example in the docs that is now fixed: input CreateTaskInput {
name: String!
notes: [CreateNoteInput!] @create
} |
…-input' into fix-create-upsert-update-list-of-input
…-input' into fix-create-upsert-update-list-of-input
🤔 I did a merge with upstream before I started. Never mind, looks like it still contains the fix. |
AFAIK, doing that in PHPStorm does not automatically pull upstream? |
I think this is everything right? |
Did it through command line git. |
Yeah, great job! Thanks a lot for taking the time to write proper tests. I am going to release a new version right now. |
Did I miss something? I thought there is no need to use input CreateUserInput {
name: String
tasks: [CreateTaskInput!] @create
} It still works also without |
@lorado without input CreateUserInput {
name: String
tasks: [CreateTaskHasMany!]
}
input CreateTaskHasMany {
create: [CreateTaskInput!]
} You can skip that layer if you know that all you are ever going to do with that relation is specifically create. |
Added Docs for all relevant versionsResolves #1315
Changes
Pass a new instance of the model to the actual update method.
Breaking changes
None