Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscriber reference from topic when deleted #1288

Merged
merged 20 commits into from
Apr 15, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO to remove check for missing operation name
  • Loading branch information
spawnia committed Apr 15, 2020
commit ddb0d77af3f8934d57f44a67475104211dc21892
2 changes: 2 additions & 0 deletions src/Subscriptions/Subscriber.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ public function __construct(
ResolveInfo $resolveInfo
) {
$operationName = $resolveInfo->operation->name;

// TODO remove that check and associated tests once graphql-php covers that validation https://github.com/webonyx/graphql-php/pull/644
if (! $operationName) {
throw new SubscriptionException(self::MISSING_OPERATION_NAME);
}
Expand Down