Access nested inputs with dot notation in find option of @can #1216

[andershagbard]

• Added or updated tests
• Added Docs for all relevant versions
• Updated CHANGELOG.md

Resolves #1162

Changes
The find method of the can directive now uses Arr::get, to search the model. This allows to pass a string in a dot notation like data.foo.bar.

Breaking changes
Previously it would throw an Undefined Index Error if the string did not map to a value. Now it will throw a DefinitionException.

[spawnia]

This looks really clean, good work.

Previously it would throw an Undefined Index Error if the string did not map to a value. Now the value will be defaulted to null, and throw a ModelNotFoundException.

This kind of breakage is fine in a new minor version.

What do you think about adding an explicit exception for that case? It seems like it is distinct from not finding a model.

[andershagbard]

What do you think about adding an explicit exception for that case? It seems like it is distinct from not finding a model.

Good idea. Just a generic server exception?

throw new \Exception("Undefined index. Could not find $find");

[spawnia]

I think that the onus is on the developer, they should just make the argument required.

We usually utilize the *Manipulator directive interfaces for this. They contain functions that are run during schema validation, so we could just throw a DefinitionException there to enforce the argument is defined as non-null !.

[andershagbard]

Updated

[spawnia]

Nicely done, thank you