Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to extend input, interface and enum types #1203

Merged
merged 5 commits into from
Feb 24, 2020
Merged

Add support to extend input, interface and enum types #1203

merged 5 commits into from
Feb 24, 2020

Conversation

faiverson
Copy link
Contributor

  • Added or updated tests

Resolves #1202

@spawnia
Copy link
Collaborator

spawnia commented Feb 20, 2020

Thank you for this PR, looks pretty good overall. With some polish, it should be good to go.

An entry in the CHANGELOG would be great, too.

@faiverson
Copy link
Contributor Author

faiverson commented Feb 21, 2020 •
edited
Loading

An entry in the CHANGELOG would be great, too.

Done in the new commit

@spawnia spawnia changed the title support to extend input, interface and enum types Add support to extend input, interface and enum types Feb 24, 2020
@spawnia spawnia merged commit 9c9fe88 into nuwave:master Feb 24, 2020
@faiverson faiverson deleted the extending-schema branch February 24, 2020 12:35
spawnia pushed a commit that referenced this pull request Mar 15, 2020
@faiverson @spawnia
Add support to extend input, interface and enum types (#1203)
9638293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spawnia spawnia spawnia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extending input types
2 participants
@faiverson @spawnia