change name to input argument x injectArgs

nuwave · Nov 12, 2019 · 3ba59d4 · 3ba59d4
1 parent a3b9eb2
commit 3ba59d4
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 27 deletions.
diff --git a/docs/master/api-reference/directives.md b/docs/master/api-reference/directives.md
@@ -531,11 +531,11 @@ type Mutation {
 }
 ```
 
-You can pass the input variables as arguments to the policy setting `input` argument
+You can pass the input variables as arguments to the policy setting `injectArgs` argument
 ```graphql
 type Mutation {
     createPost(input: PostInput): Post
-        @can(ability: "create", input: "true")
+        @can(ability: "create", injectArgs: "true")
 }
 ```
 Now you will have access to `PostInput` values in the policy 

diff --git a/src/Schema/Directives/CanDirective.php b/src/Schema/Directives/CanDirective.php
@@ -68,11 +68,11 @@ public static function definition(): string
   Additional arguments that are passed to `Gate::check`. 
   """
   args: [String!]
-    """
+  """
   Send input data as arguments to the policy. 
   Set false by default
   """
-  input: Boolean!
+  injectArgs: Boolean!
 ) on FIELD_DEFINITION
 SDL;
     }
@@ -158,8 +158,9 @@ protected function authorize($user, $model): void
     protected function getAdditionalArguments(): array
     {
         $directiveArgs = (array) $this->directiveArgValue('args');
-        $inputArgs = $this->directiveArgValue('input') === true ? [$this->args] : [];
-
+        $inputArgs = $this->directiveArgValue('injectArgs') === true
+            ? [$this->args]
+            : [];
         return array_merge($directiveArgs, $inputArgs);
     }
 }
diff --git a/tests/Unit/Schema/Directives/CanDirectiveTest.php b/tests/Unit/Schema/Directives/CanDirectiveTest.php
@@ -161,8 +161,8 @@ public function testSendInputArgumentToPolicy(): void
         $this->be(new User);
         $this->schema = '
         type Query {
-            users(key1: String, key2: String, key3: String): [User]!
-                @can(ability:"severalArgs", input: true)
+            user(foo: String): User!
+                @can(ability:"severalArgs", injectArgs: true)
                 @field(resolver: "'.$this->qualifyTestResolver('resolveUser').'")
         }
         
@@ -171,24 +171,20 @@ public function testSendInputArgumentToPolicy(): void
         }
         ';
 
-        $variables = [
-            'key1' => 'foo',
-            'key2' => 'foo2',
-            'key3' => 'foo3',
-        ];
-
-        $this->postGraphQL(
-            [
-                'operationName' => 'Users',
-                'query' => 'query Users($key1: String, $key2: String, $key3: String) {
-                                users(key1: $key1, key2: $key2, key3: $key3) {
-                                    name
-                                }
-                            }
-                            ',
-                'variables' => $variables,
-            ]
-        )->assertOk();
+
+        $this->graphQL('
+        {
+            user(foo: "bar"){
+                name
+            }
+        }
+        ')->assertJson([
+            'data' => [
+                'user' => [
+                    'name' => 'foo',
+                ],
+            ],
+        ]);
     }
 
     public function resolveUser(): User

diff --git a/tests/Utils/Policies/UserPolicy.php b/tests/Utils/Policies/UserPolicy.php
@@ -35,6 +35,6 @@ public function dependingOnArg($viewer, bool $pass): bool
 
     public function severalArgs($user, array $input): bool
     {
-        return $input['key1'] === 'foo' && $input['key2'] === 'foo2' && $input['key2'] === 'foo3';
+        return $input['foo'] === 'bar';
     }
 }