fix: remove unexported method v3 Service interface #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an unexported method in an interface makes it not possible to implement from a different package e.g. Trying to create a mock implementation leads to this error: Type cannot implement 'Service' as it has a non-exported method and is defined in a different package
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 54.30% 54.30%
=======================================
Files 20 20
Lines 1799 1799
=======================================
Hits 977 977
Misses 822 822 ☔ View full report in Codecov by Sentry. |
|
@yannickstruyf3 @tuxtof FYI. (For some reason I can't add you as reviewers) |
|
this method exists in the same file? listServiceGroups(ctx context.Context, getEntitiesRequest *DSMetadata) (*ServiceGroupListResponse, error) -- 2190 | func (op Operations) listServiceGroups(ctx context.Context, getEntitiesRequest *DSMetadata) (*ServiceGroupListResponse,… we can make it capital letter. just want to confirm if it needs to be exported. am sure no one might be using it then outside |
|
/lgtm |
deepakm-ntnx
approved these changes
Jan 5, 2024
thunderboltsid
approved these changes
Jan 5, 2024
8724a6b
into
nutanix-cloud-native:main
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an unexported method in an interface makes it not possible to implement from a different package
e.g. Trying to create a mock implementation leads to this error: