Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: category race condition by updating Nutanix CSI to 3.0.0-2458 #814

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

dkoshkin
Copy link
Contributor

What problem does this PR solve?:
This version fixes a race condition when creating multiple PVs.

https://github.com/nutanix-scratch/helm/releases/tag/nutanix-csi-storage-3.0.0-2458

Tested

kubectl get deploy -n ntnx-system -o yaml | grep "image: docker.io/nutanix/ntnx-csi"
          image: docker.io/nutanix/ntnx-csi:3.0.0-2458
kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                                                                    STORAGECLASS     VOLUMEATTRIBUTESCLASS   REASON   AGE
pvc-d13bf2f8-644d-424b-a347-811a78bdd11b   10Gi       RWO            Delete           Bound    e2e-volume-pvc-bound-to-pv/pv-volume-volume-pvc-bound-to-pv-tester-2-0   nutanix-volume   <unset>                          8m36s
pvc-f1d988d2-5325-42cd-b873-6ed8649a4001   10Gi       RWO            Delete           Bound    e2e-volume-pvc-bound-to-pv/pv-volume-volume-pvc-bound-to-pv-tester-0     nutanix-volume   <unset>                          8m37s

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

@dkoshkin dkoshkin self-assigned this Jul 18, 2024
@github-actions github-actions bot added the fix label Jul 18, 2024
@dkoshkin dkoshkin changed the title fix: race condition by updating Nutanix CSI to 3.0.0-2458 fix: category race condition by updating Nutanix CSI to 3.0.0-2458 Jul 18, 2024
@github-actions github-actions bot added fix and removed fix labels Jul 18, 2024
This version fixes a race condition when creating multiple PVs.
Copy link
Contributor

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming before we release, we will be going to a released version instead of dev/scratch helm chart patch.

@dkoshkin
Copy link
Contributor Author

assuming before we release, we will be going to a released version instead of dev/scratch helm chart patch.

Yep thats correct.

@dkoshkin dkoshkin force-pushed the dkoshkin/fix-race-with-csi-3.0.0-2458 branch from 740b6c6 to 6140dda Compare July 18, 2024 22:18
@dkoshkin dkoshkin requested a review from supershal July 18, 2024 22:21
@dkoshkin dkoshkin merged commit 8fb5abe into main Jul 18, 2024
15 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/fix-race-with-csi-3.0.0-2458 branch July 18, 2024 22:49
@dkoshkin dkoshkin mentioned this pull request Jul 19, 2024
dkoshkin added a commit that referenced this pull request Jul 19, 2024
🤖 I have created a release *beep* *boop*
---


## 0.13.1 (2024-07-19)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Fixes 🔧
* fix: generated API file by @dkoshkin in
#811
* fix: category race condition by updating Nutanix CSI to 3.0.0-2458 by
@dkoshkin in
#814
* fix: use production repo for Nutanix CSI to 3.0.0-2458 by @dkoshkin in
#815


**Full Changelog**:
v0.13.0...v0.13.1

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants