Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update CAPI to v1.9.3 #1010

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dkoshkin
Copy link
Contributor

What problem does this PR solve?:
Update CAPI to the latest released version https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.9.3

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

Special notes for your reviewer:

obj, err := external.Get(ctx, cli, ref, ref.Namespace)
obj, err := external.Get(ctx, cli, ref)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small signature change here.

@jimmidyson
Copy link
Member

Can we do this as part of normal dependabot update PR #1006 ?

@SandhyaRavi2403
Copy link

Can we do this as part of normal dependabot update PR #1006 ?

I did try to update the changes @jimmidyson , couldn't push the changes

ERROR: Permission to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix.git denied to SandhyaRavi2403.

@jimmidyson
Copy link
Member

Can we do this as part of normal dependabot update PR #1006 ?

I did try to update the changes @jimmidyson , couldn't push the changes

ERROR: Permission to nutanix-cloud-native/cluster-api-runtime-extensions-nutanix.git denied to SandhyaRavi2403.

@SandhyaRavi2403 I'll grant you permissions for next time - thanks for trying though! I've fixed this up now in the dependabot PR.

@dkoshkin
Copy link
Contributor Author

Can we do this as part of normal dependabot update PR #1006 ?

We could do that @jimmidyson, but do we really want to add all these other changes in that PR?
If this merges that AFAIK that dependabot PR would get rebased and only have the other changes after.

@jimmidyson
Copy link
Member

@dkoshkin OK let's do it this way around.

Why is this labelled as do not merge btw?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants