fix: validates PC IP is outside Load Balancer IP Range #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ad7d73 to
b519340
Compare
dkoshkin
reviewed
Dec 13, 2024
42877e3 to
ce6738a
Compare
thunderboltsid
approved these changes
Dec 17, 2024
6e96d3c to
b9cc1f8
Compare
thunderboltsid
approved these changes
Dec 18, 2024
Merged
dkoshkin
added a commit
that referenced
this pull request
Jan 16, 2025
🤖 I have created a release *beep* *boop* --- ## 0.25.0 (2025-01-16) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Virtual IP configuration to set different address/port by @dkoshkin in #986 * feat: update addon versions by @dkoshkin in #997 * feat: COSI controller Addon by @dkoshkin in #1008 ### Fixes 🔧 * fix: check HelmReleaseReadyCondition when status is up-to-date by @dkoshkin in #989 * fix: update CoreDNS mapping file by @dkoshkin in #998 * fix: validates PC IP is outside Load Balancer IP Range by @manoj-nutanix in #1001 * fix: update COSI controller image to fix CVEs by @dkoshkin in #1012 * fix(deps): Update Nutanix CCM Version by @thunderboltsid in #1016 * fix: update AWS CCM to latest versions by @dkoshkin in #1013 ### Other Changes * refactor: new waiter functionality in helmAddonApplier by @dkoshkin in #988 * build: Properly ignore ntnx API client from dependabot by @jimmidyson in #995 **Full Changelog**: v0.24.0...v0.25.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
webhook errors out if NUTANIX_ENDPOINT IP falls in Load Balancer IP Range. It only implements dumb check which compares PC IP with Load Balancer IP Range. It's complex to achieve with CEL so going with webhook as we'll need to use regex(isIP() func is not working for cluster variables) to extract IP from PC URL and do string compare which not robust as we can do error handling through webhook.
Which issue(s) this PR fixes:
Fixes #
https://jira.nutanix.com/browse/NCN-102628
How Has This Been Tested?:
Special notes for your reviewer: