Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the checkout ref for incorporating PR #455

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

Since we moved to using pull_request_target which executes the workflow in the context of the base repository but the default HEAD that gets checked out is now the main branch rather than the PR. This ensures the pull request HEAD is checked out before running the workflow.

Since we moved to using pull_request_target which executes the
workflow in the context of the base repository but the default HEAD
that gets checked out is now the main branch rather than the PR.
This ensures the pull request HEAD is checked out before running the
workflow.
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.74%. Comparing base (7dd3dd4) to head (215980b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   31.74%   31.74%           
=======================================
  Files          14       14           
  Lines        1367     1367           
=======================================
  Hits          434      434           
  Misses        933      933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tuxtof tuxtof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thunderboltsid thunderboltsid merged commit 098d8d6 into main Jul 9, 2024
9 of 11 checks passed
@thunderboltsid thunderboltsid deleted the issue/checkout-fix branch July 9, 2024 11:23
@thunderboltsid thunderboltsid added the ignore-for-release Internal change to not include in Release Notes label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Internal change to not include in Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants