Cherry-pick PR #436 to release-v1.3 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v1.3 #441 +/- ##
================================================
+ Coverage 17.84% 18.50% +0.65%
================================================
Files 22 22
Lines 2146 2156 +10
================================================
+ Hits 383 399 +16
+ Misses 1763 1757 -6 ☔ View full report in Codecov by Sentry. |
deepakm-ntnx
approved these changes
May 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refactor SetupWithManager function to call Build and Watch explicitly instead of calling complete. Also add ClusterUnpausedAndInfrastructureReady predicate to the watch call.
8effc57 to
4effc2b
Compare
|
/retest |
✅ None of your dependencies violate policy! |
|
/test e2e-k8s-upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick Details