Explicitly set a rate limiter for controller config #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84cff8c to
db0697d
Compare
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 25.18% 26.91% +1.72%
==========================================
Files 19 19
Lines 1326 1360 +34
==========================================
+ Hits 334 366 +32
- Misses 992 994 +2 ☔ View full report in Codecov by Sentry. |
db0697d to
8728c09
Compare
|
just documenting here for completeness. https://stuartleeks.com/posts/error-back-off-with-controller-runtime/ |
This article is slightly outdated. Newer versions of the controller-runtime directly use |
dkoshkin
previously approved these changes
Apr 23, 2024
8728c09 to
199ce30
Compare
|
/retest |
dkoshkin
approved these changes
Apr 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, dkoshkin, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
199ce30 to
277e75b
Compare
|
/retest |
deepakm-ntnx
approved these changes
Apr 24, 2024
|
pls create a tracker to test the behavior in general either manual or automated |
The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
277e75b to
394d9cb
Compare
|
/retest |
1 similar comment
|
/retest |
dkoshkin
approved these changes
Apr 24, 2024
deepakm-ntnx
approved these changes
Apr 24, 2024
thunderboltsid
added a commit
that referenced
this pull request
Apr 29, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
Apr 29, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
Apr 29, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
Apr 29, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 2, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 10, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
thunderboltsid
added a commit
that referenced
this pull request
May 14, 2024
…ig (#416) The rate limiter base delay and max delay values can be configured using flags. The default values are 500ms for base delay and 15min for max delay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limiter is a MaxOfRateLimiter similar to the default one. However, now the base delay, max delay, bucket size, and qps can be configured using flags. The default values are 500ms for base delay and 15min for max delay in the exponential backoff limiter (custom values) and 10 qps and 100 bucket size for the bucket limiter (same as the default one).