Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable for setting the additional categories on cluster #396

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

thunderboltsid
Copy link
Contributor

The diff also includes a patch to set the additional categories on nutanixmachinetemplate resources for control plane and worker machine deployments.

deepakm-ntnx
deepakm-ntnx previously approved these changes Mar 20, 2024
Copy link
Contributor

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check the comments before merging

@deepakm-ntnx deepakm-ntnx force-pushed the jira/krbn-8091 branch 2 times, most recently from ce5c61d to b48fb65 Compare April 1, 2024 15:59
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.63%. Comparing base (4a18e44) to head (7c30be7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files          19       19           
  Lines        1303     1303           
=======================================
  Hits          334      334           
  Misses        969      969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid thunderboltsid requested a review from dkoshkin April 2, 2024 18:51
Base automatically changed from jira/krbn-8091 to main April 2, 2024 20:52
@thunderboltsid thunderboltsid dismissed deepakm-ntnx’s stale review April 2, 2024 20:52

The base branch was changed.

dkoshkin
dkoshkin previously approved these changes Apr 2, 2024
The diff also includes a patch to set the additional categories on
nutanixmachinetemplate resources for control plane and worker
machine deployments.
@thunderboltsid thunderboltsid dismissed dkoshkin’s stale review April 2, 2024 20:55

The merge-base changed after approval.

@thunderboltsid
Copy link
Contributor Author

/retest

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/meow

@nutanix-cn-prow-bot
Copy link

@adiantum: cat image

In response to this:

/lgtm
/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 1d22fb9 into main Apr 3, 2024
12 of 13 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8092 branch April 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants