Update controller-gen version to 0.14.0 #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickstruyf3
previously approved these changes
Mar 13, 2024
|
@thunderboltsid: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ca2c9a3 to
c1cb8b8
Compare
Go1.22 broke controller-gen version 0.8.0 through 0.13.0. Go1.22 drops support for GO111MODULE=off go get -u in legacy gopath mode.
c1cb8b8 to
a2d6d71
Compare
✅ None of your dependencies violate policy! |
|
Closing this PR and moving the commits to #390 as E2Es won't pass without Kubernetes 1.29 support on that PR and unit tests on that PR won't pass without changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go1.22 had a change that broke controller-gen version 0.8.0 through 0.13.0.
Go1.22 also drops support for GO111MODULE=off go get -u. This PR replaces those directives with go install ones.