fix: adds a function to properly sanitize the address

pkg/client/client.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
+	"net/url"
 	"os"
 	"path/filepath"
 
@@ -43,6 +44,8 @@ const (
 	capxNamespaceKey    = "POD_NAMESPACE"
 )
 
+var ErrPrismAddressNotSet = fmt.Errorf("cannot get credentials if Prism Address is not set")
+
 type NutanixClientHelper struct {
 	secretInformer    coreinformers.SecretInformer
 	configMapInformer coreinformers.ConfigMapInformer
@@ -63,9 +66,11 @@ func (n *NutanixClientHelper) GetClientFromEnvironment(ctx context.Context, nuta
 	// If PrismCentral is set, add the required env provider
 	prismCentralInfo := nutanixCluster.Spec.PrismCentral
 	if prismCentralInfo != nil {
-		if prismCentralInfo.Address == "" {
-			return nil, fmt.Errorf("cannot get credentials if Prism Address is not set")
+		address, err := validateAndSanitizePrismCentralInfoAddress(prismCentralInfo.Address)
+		if err != nil {
+			return nil, err
 		}
+		prismCentralInfo.Address = address
 		if prismCentralInfo.Port == 0 {
 			return nil, fmt.Errorf("cannot get credentials if Prism Port is not set")
 		}
@@ -116,7 +121,6 @@ func (n *NutanixClientHelper) GetClientFromEnvironment(ctx context.Context, nuta
 		*npe,
 		n.secretInformer,
 		n.configMapInformer))
-
 	// init env with providers
 	env := environment.NewEnvironment(
 		providers...,
@@ -209,3 +213,17 @@ func GetCredentialRefForCluster(nutanixCluster *infrav1.NutanixCluster) (*creden
 
 	return prismCentralInfo.CredentialRef, nil
 }
+
+func validateAndSanitizePrismCentralInfoAddress(address string) (string, error) {
+	if address == "" {
+		return "", ErrPrismAddressNotSet
+	}
+	u, err := url.Parse(address)
+	if err != nil {
+		return "", fmt.Errorf("failed to parse url from given address %w", err)
+	}
+	if u.Scheme != "" || u.Port() != "" {
+		return u.Hostname(), nil
+	}
+	return address, nil
+}

pkg/client/client_test.go

@@ -0,0 +1,52 @@
+package client
+
+import (
+	"errors"
+	"testing"
+)
+
+func Test_validateAndSanitizePrismCentralInfoAddress(t *testing.T) {
+	tests := []struct {
+		name            string
+		providedAddress string
+		expectedAddress string
+		expectedErr     error
+	}{
+		{
+			"with scheme",
+			"https://prism-bowser.ntnxsherlock.com",
+			"prism-bowser.ntnxsherlock.com",
+			nil,
+		},
+		{
+			"with scheme and port",
+			"https://prism-bowser.ntnxsherlock.com:9440",
+			"prism-bowser.ntnxsherlock.com",
+			nil,
+		},
+		{
+			"as expected from the user",
+			"prism-bowser.ntnxsherlock.com",
+			"prism-bowser.ntnxsherlock.com",
+			nil,
+		},
+		{
+			"not set",
+			"",
+			"",
+			ErrPrismAddressNotSet,
+		},
+	}
+
+	for _, test := range tests {
+		s, err := validateAndSanitizePrismCentralInfoAddress(test.providedAddress)
+		if err != nil {
+			if test.expectedErr == nil || !errors.Is(err, test.expectedErr) {
+				t.Errorf("validateAndSanitizePrismCentralInfoAddress() error = %v, wantErr = %v", err, test.expectedErr)
+			}
+		}
+		if s != test.expectedAddress {
+			t.Errorf("validateAndSanitizePrismCentralInfoAddress() got = %v, want = %v", s, test.expectedAddress)
+		}
+	}
+}