This repository has been archived by the owner on Jan 17, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tomasz,
I just verified that the unit test still pass with the jtds version 1.2.7.
In addition to that I also added support for oracle 9/10/11 - all unit tests pass.
I tested this with oracle 11, but this analytic function (row_num) is part of the SQL99
standard which is available since Oracle 9 IIRC.
I also introduced a small helper class *) which generates the sql99 conform sql select statement
with pagination support. This works for sql server 2008 as well as for oracle.
*) I thought introducing an additional SqlGenerator base class (AbstractSql99SqlGenerator) would be to much atm... ;-)
Hope this helps :)
Best regards,
Tom