Skip to content
This repository has been archived by the owner on Jan 17, 2019. It is now read-only.

Support for Oracle (9/10/11) #3

Closed
wants to merge 2 commits into from

Conversation

thomasdarimont
Copy link
Contributor

Hello Tomasz,

I just verified that the unit test still pass with the jtds version 1.2.7.

In addition to that I also added support for oracle 9/10/11 - all unit tests pass.
I tested this with oracle 11, but this analytic function (row_num) is part of the SQL99
standard which is available since Oracle 9 IIRC.

I also introduced a small helper class *) which generates the sql99 conform sql select statement
with pagination support. This works for sql server 2008 as well as for oracle.

*) I thought introducing an additional SqlGenerator base class (AbstractSql99SqlGenerator) would be to much atm... ;-)

Hope this helps :)

Best regards,
Tom

…7 of JTDS JDBC Driver

- Splitt up of mssql test-packages in /mssql and /mssql2012
- minor cleanup
- Unit tests pass for Oracle Version 9/10/11
- Introduced small Helper-Class for SQL99 Compatible SQL Select Statements with pagination support
@nurkiewicz
Copy link
Owner

Wow, big thank you! Feel free to add yourself to contributors in pom.xml. One thing that's bothering me is the absence of ojdbc6*.jar driver in Travis maven repository. This causes your pull request to fail on CI. I have to think about, maybe they can add custom JARs?

In the meantime I'll merge your pull request into a branch in this repository.

@nurkiewicz
Copy link
Owner

I pushed your changes to oracle branch. Unfortunately it doesn't build due to a missing dependency on ojdbc6.

I love your changes but before I merged them to mainline I have to think of some plan to keep CI build green. Continuous testing is more important than new features, even though they are great and valuable. Weel keep you informed, or maybe you have some idea?

@nurkiewicz
Copy link
Owner

Oracle support merged to master, will be included in version 0.3. Oracle tests are only executed with mvn test -Poracle profile to avoid problems with JDBC driver not available in public maven repository. Thank your for your contribution!

@nurkiewicz nurkiewicz closed this Mar 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants