Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance with GPL license: request for updated firmware source code #5

Open
wants to merge 1 commit into
base: nuphy-keyboards
Choose a base branch
from

Conversation

arthurgeek
Copy link

Hello Nuphy Team,

⁤I recently purchased the Gem80 keyboard and I noticed the release dates of new firmware updates available in binary form on your website and the dates of the source code available in this GitHub repository do not match.

⁤As the QMK firmware is released under the GPL license, source code for all distributed software versions must be provided.

⁤This requirement is not only a legal obligation but also an important aspect of being a good citizen within the open-source community.

Failing to do so could have serious consequences for both your users and your company.

Therefore, I strongly recommend you to make appropriate changes in this repository as soon as possible by providing the corresponding source code for all firmware versions that you had distributed in your website.

By doing so, not only will you meet your legal obligations, but you will also build trust within your user community.

@hloeung
Copy link

hloeung commented May 6, 2024

FWIW, there has been discussions about this with the Air75 V2 here - qmk#21949

@withthelemons
Copy link

This is very important, especially for Gem80. The changelog lists "Optimized debouncing algorithm" while this repo still seems to use the old debouncing method.

Prens282 pushed a commit to Prens282/qmk that referenced this pull request Jun 25, 2024
…handlers-2

feat: added additional RGB keycode handlers
@norbertkeri
Copy link

Does the code in this repository work? I tried pulling it, but the chibios submodule points to a nonexistant commit, and force updating it to latest causes compile errors.

git submodule update --init --recursive
fatal: remote error: upload-pack: not our ref a29eefa36b3378b03be509d09c530cb86ffc049f
fatal: Fetched in submodule path 'chibios', but it did not contain a29eefa36b3378b03be509d09c530cb86ffc049f

Forcing an update with git submodule update --remote --force --init --recursive pulls down the latest commits of the submodules, but then compiling fails:

qmk compile -kb nuphy/air60_v2/ansi -km via
Ψ Compiling keymap with make -r -R -f builddefs/build_keyboard.mk -s KEYBOARD=nuphy/air60_v2/ansi KEYMAP=via KEYBOARD_FILESAFE=nuphy_air60_v2_ansi TARGET=nuphy_air60_v2_ansi_via INTERMEDIATE_OUTPUT=.build/obj_nuphy_air60_v2_ansi_via VERBOSE=false COLOR=true SILENT=false QMK_BIN="qmk"


⚠ nuphy/air60_v2/ansi: Build marker "keyboard.json" not found.
arm-none-eabi-gcc (Arch Repository) 14.1.0
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/nuphy/air60_v2/ansi/side.c                                                    In file included from ./lib/chibios/os/hal/osal/rt-nil/osal.h:32,
                 from ./lib/chibios/os/hal/include/hal.h:30,
                 from platforms/chibios/platform_deps.h:18,
                 from quantum/quantum.h:18,
                 from keyboards/nuphy/air60_v2/ansi/ansi.h:20,
                 from keyboards/nuphy/air60_v2/ansi/side.c:18:
./lib/chibios/os/rt/include/ch.h:125:10: fatal error: chlib.h: No such file or directory
  125 | #include "chlib.h"
      |          ^~~~~~~~~
compilation terminated.
 [ERRORS]
 | 
 | 
 | 
make: *** [builddefs/common_rules.mk:373: .build/obj_nuphy_air60_v2_ansi_via/side.o] Error 1

@FouzR
Copy link

FouzR commented Nov 10, 2024

New 2.1.0 firmware versions are out, but the source doesn't seem to be updated for that on most of the keyboards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants