Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test on NuoDB version #208

Merged
merged 8 commits into from
May 19, 2021
Merged

Skip test on NuoDB version #208

merged 8 commits into from
May 19, 2021

Conversation

sivanov-nuodb
Copy link
Collaborator

Changes

  • Database restore using user-defined storage groups is supported in NuoDB 4.2+. Disable TestKubernetesRestoreWithStorageGroups test for unsupported NuoDB versions
  • Get logs for all SM pods if the restore fails for some reason

@sivanov-nuodb sivanov-nuodb added the meta Exclude from Changelog label May 18, 2021
@@ -146,6 +146,7 @@ func TestKubernetesRestoreWithStorageGroups(t *testing.T) {
if os.Getenv("NUODB_LICENSE") != "ENTERPRISE" && os.Getenv("NUODB_LICENSE_CONTENT") == "" {
t.Skip("Cannot test multiple SMs without the Enterprise Edition")
}
testlib.SkipTestOnNuoDBVersionCondition(t, "< 4.2")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

Copy link
Contributor

@NikTJ777 NikTJ777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@sivanov-nuodb sivanov-nuodb merged commit c8a0f5f into master May 19, 2021
@sivanov-nuodb sivanov-nuodb deleted the sivanov/DB-33461 branch May 19, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Exclude from Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants