Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Mobile classes for gallery and carousel #485

Merged
merged 1 commit into from
Feb 3, 2023
Merged

✨ Mobile classes for gallery and carousel #485

merged 1 commit into from
Feb 3, 2023

Conversation

mircea-pavel-anton
Copy link
Contributor

Fixes #482

@mircea-pavel-anton mircea-pavel-anton changed the base branch from main to dev January 25, 2023 13:36
@nunocoracao
Copy link
Owner

Hello @mirceanton do we really need this?
I think without this CSS you were already able to use md:CLASS

@mircea-pavel-anton
Copy link
Contributor Author

I think the css classes were not present before. I tried to set the class but nothing was happening. Maybe i was doing something wrong?

@nunocoracao
Copy link
Owner

Let me test it... I think you probably need to re-compile tailwind but don't need to add the classes to the css

@nunocoracao
Copy link
Owner

@mirceanton not forgotten just won't have time to review this now

@nunocoracao
Copy link
Owner

I merged the changes, the code doesn't work

@nunocoracao
Copy link
Owner

@mirceanton had to redo the ode... check this commit if interested
5ab7918

@mircea-pavel-anton
Copy link
Contributor Author

@nunocoracao ah... I see where I went wrong... Sorry about that! 😅

@mircea-pavel-anton mircea-pavel-anton deleted the feature-482-mobile-classes-for-gallery branch February 3, 2023 21:49
@nunocoracao
Copy link
Owner

no problem. next time test it please

@mircea-pavel-anton
Copy link
Contributor Author

I did test similar changes directly on my website by doing the modifications locally, but I think I only tested on mobile. Perhaps the "mobile-specific" classes were overriding the "regular" ones and that's why I assumed it was working fine.

Yeah... note taken! I'll be more thorough with my testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Mobile specific classes for gallery width
2 participants