-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Mobile classes for gallery and carousel #485
✨ Mobile classes for gallery and carousel #485
Conversation
Hello @mirceanton do we really need this? |
I think the css classes were not present before. I tried to set the class but nothing was happening. Maybe i was doing something wrong? |
Let me test it... I think you probably need to re-compile tailwind but don't need to add the classes to the css |
@mirceanton not forgotten just won't have time to review this now |
I merged the changes, the code doesn't work |
@mirceanton had to redo the ode... check this commit if interested |
@nunocoracao ah... I see where I went wrong... Sorry about that! 😅 |
no problem. next time test it please |
I did test similar changes directly on my website by doing the modifications locally, but I think I only tested on mobile. Perhaps the "mobile-specific" classes were overriding the "regular" ones and that's why I assumed it was working fine. Yeah... note taken! I'll be more thorough with my testing! |
Fixes #482