-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ shortcode gallery #450
✨ shortcode gallery #450
Conversation
@nunocoracao For this one, I decided to go with the verbose list as a solution since it makes it that much more easier to set the custom width for each element. |
@mirceanton I don't agree with this implementation.
|
@nunocoracao Okay, I'll see what I can do. Sorry if this isn't following best practices, I don't normally do HTML, CSS & JS, it's all a bit new to me. |
@nunocoracao As for the javascript import, should I simply dump the minified js into a file under |
For the CSS it will be super clear if you look at other shortcodes or partials. Tailwindcss docs are also super great. For the imports check what is happening for typeit for example.
Sounds like a lot of effort but it will make everything super easy to update and maintain. My advice, check if you really need a new dependency for this or if could be achieved using just tailwind. Aka a quick search for twailwind image gallery might surprise you. |
@mirceanton if you want I can open a feature branch an we can collab before merging to dev (release branch) |
@nunocoracao that would be amazing! This is the first time I'm touching this tech stack so I am quite lost to be honest. |
merging into feature branch for final alterations |
Fixes #428