✨ Support Seline Analysis #1640
Conversation
| | Name | Default | Description | | ||
| |-----------------------------------|-----------|-------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `selineAnalytics.token` | _Not set_ | The token generated by Seline Analytics for the website. Refer to the [Analytics docs]({{< ref "partials#analytics" >}}) for more details. | | ||
| | `selineAnalytics.enableTrackEvent` | true | When set to `true` track event will add automatically. If you do not want to add track event, set it to `false`. | |
There was a problem hiding this comment.
These should definitely default to false or not set to match all the other analytics engines. Otherwise, you're enabling it for every user by default.
There was a problem hiding this comment.
These should definitely default to false or not set to match all the other analytics engines. Otherwise, you're enabling it for every user by default.
In my opinion enableTrackEvent=true is recommended for optimal data tracking and display.
If you want to customize event tracking, might set it to false, and then add manually invoking umami.track() or seline.track() for specific events.
However, for most users this customization is unnecessary.
There was a problem hiding this comment.
I see, there's an outer guard here in analytics/main.html.
| @@ -10,6 +10,7 @@ | |||
| </script> | |||
| {{ end }} | |||
|
|
|||
| {{ if .Site.Params.umamiAnalytics.enableTrackEvent | default true }} | |||
There was a problem hiding this comment.
Same comment here -- I don't think these should be defaulting to enabled.
#1639
enableTrackEvent