TestConverter: added check for attachment path - if it starts with file:// scheme #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
@OsirisTerje I've added two unit tests which check that correct amount of test attachments was converted and that all pathes start with the only "file://" value. I guess it's enough for that part. |
|
Superb! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes the problem from issue 494.
I added constant fileUriScheme into helper method
AttachmentSet ParseAttachments(XmlNode resultNode).Then I added check for each path in attachments.
When path is not empty or not already started with fileUriScheme, fileUriScheme value is added at the beginning of the original path.