Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to filter by TestCategory again #453

Merged
merged 3 commits into from
Feb 18, 2018
Merged

Make it possible to filter by TestCategory again #453

merged 3 commits into from
Feb 18, 2018

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Feb 15, 2018

Fixes #452

@jnm2 jnm2 changed the title Jnm2/fix category filter Make it possible to filter by TestCategory again Feb 15, 2018
@jnm2 jnm2 requested a review from OsirisTerje February 15, 2018 04:49
This was referenced Feb 15, 2018
Closed
Merged
Closed
@jnm2
Copy link
Contributor Author

jnm2 commented Feb 15, 2018

Hooray, I have nothing left to do! The Mono.Cecil removal PR is waiting on this one at #454.

OsirisTerje
OsirisTerje approved these changes Feb 18, 2018
View reviewed changes
Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good you fixed this. Too bad it wasn't detected earlier though.
Changes looks good.

@OsirisTerje OsirisTerje merged commit 77c85b5 into master Feb 18, 2018
@jnm2 jnm2 deleted the jnm2/fix_category_filter branch February 18, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OsirisTerje OsirisTerje OsirisTerje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnm2 @OsirisTerje