Reading traits/properties from xml test-run tree using cache #406
Conversation
- Removed recursion in AddTraitsFromTestNode method. - Cached the class and assembly level traits so that we don't need to traverse the tree again. - Reading test-case, test-suite and assembly level attributes based on the tree structure.
Added a test to check the cache built.
…hod. Thus this will not work with older object models.
Reading tratis/properties from xml test-run tree using cache.
|
I see you are using the word attributes in several places although the code had nothing to do with attributes. The adapter gets properties from NUnit and creates traits. Some properties (not all) correspond to NUnit attributes but the adapter doesn't know that. |
|
Based on this line: |
|
All tests I have thought of have now been added and are green. I have also tested this with comparison to the current adapter on different test code scenarios, and it returns the same. |
|
Yes, as well as the property. |
| @@ -41,24 +40,81 @@ public static void AddTrait(this TestCase testCase, string name, string value) | |||
| } | |||
| } | |||
|
|
|||
| public static void AddTraitsFromTestNode(this TestCase testCase, XmlNode test) | |||
| public static void AddTraitsFromTestNode(this TestCase testCase, XmlNode testNode, IDictionary<string,List<Trait>> propertiesCache) | |||
There was a problem hiding this comment.
nit : should we change the naming convention here also to traitsCache instead of propertiesCache.
| return string.IsNullOrEmpty(propertyName) || propertyName[0] == '_' || string.IsNullOrEmpty(propertyValue); | ||
| } | ||
|
|
||
| private static void AddTraitsToCache(IDictionary<string, List<Trait>> propertiesCache, string key, string propertyName, string propertyValue) |
See #392 and PR #401