Change DateTimeOffset.Parse to use InvariantCulture #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not change Date Times returned for current strings, but does not throw on cultures that use a different date format.
jnm2
reviewed
Aug 28, 2017
|
I can, but the only way I found how to do it (the appveyor build fail, for some reason it can't find the test runner when selecting .net core 1.0 on the project that already exists) was to add a new .net core 2.0 project and add my test in there. Is that alright? |
|
@OsirisTerje would have the best answer on that. |
|
We have currently issues with .net core 2.0, see issue #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not change Date Times returned for current strings, but does not throw on cultures that use a different date format.
Fix #372