Skip surfacing certain properties as UI groupings

[jnm2]

Description is something that people are not likely to want to group by and it introduces a lot of noise:

Likewise, per-value Timeout and per-value Repeat don't seem that useful as things to group by.

Having them as hidden traits seems fine. That way you can still search for Trait:"Repeat" in Test Explorer.

[rprouse]

Good idea, that is confusing. We should do a scan of the framework to make sure we get all of the properties users won't want to see in the UI.

[CharliePoole]

I haven't looked at the code, but here's what I think happened. We used to suppress internal attributes from appearing as traits. They were marked as beginning with an underscore. For example, once upon a time, the descrition property was _DESCRIPTION. As time went on, we added attributes for our own use that didn't use this convention and some of the old internal attributes got "normal" names. I don't think it was intentional, but just happened.

[jnm2]

That makes sense! I wondered when this ever came into play.

nunit3-vs-adapter/src/NUnitTestAdapter/CategoryList.cs

Lines 90 to 91 in 3b9e395

	// Property names starting with '_' are for internal use only
	return String.IsNullOrEmpty(propertyName) || propertyName[0] == '_' || String.IsNullOrEmpty(propertyValue);

[OsirisTerje]

This then needs to be fixed in the framework, right?

[CharliePoole]

Not necessarily. You could have a list of properties to bypass in the adapter or you could rename the properties in the framework.

[jnm2]

I just finished telling @sharwell how to determine whether an ITest is being run with a single-threaded apartment. Renaming the framework properties is something I would hope to avoid unless we first provide a strongly-typed API for it.

gitextensions/gitextensions@d1a7dcd#diff-533f1fde05a2671c2f0d36aa1abc1885R19

[rprouse]

Last time we changed names we broke other runners, so we probably don't want to do that. A list in the adaptor is a hacky solution, but it is backwards compatibile and won't break anything.

[CharliePoole]

I agree and for another reason as well. Properties don't exist for the adapter to use for grouping. That's a usage that has been retrofitted to match what the Test Explorer team wanted when they first came up with Traits and wanted to showcase it for a Build conference. It's logical to make any adaptations in the adapter.

[dzmitry-lahoda]

Issue with Description is my real biggest pain. It slows down test explorer UI to miserable. Any plan for fixing this? If this and donation page will be fixed I will donate again:)

[OsirisTerje]

The attribute Description, has been filtered off by the Test Explorer in 15.8. It is no longer displayed.

[CharliePoole]

@OsirisTerje What do you mean?

[OsirisTerje]

Sorry, misspelled, corrected.