Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace "buildstats.info" with "img.shields.io" #818

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

mikkelbu
Copy link
Member

It seems like buildstats.info is no longer working.

It seems like buildstats.info is no longer working.
Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on vacation with questionable wifi so it's tough to review this well on my phone. It looks like the myget badge may be showing a badge for the latest stable version (4.5.0) while it links to a pre release 4.6.x version. Is that expected?

@mikkelbu
Copy link
Member Author

I'm on vacation with questionable wifi so it's tough to review this well on my phone. It looks like the myget badge may be showing a badge for the latest stable version (4.5.0) while it links to a pre release 4.6.x version. Is that expected?

No - but it has always been like this :D (I think I copied the badges originally from one of the other repos). I'll update the badge to use vpre instead of v in the url, then it should show the prerelease.

Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Changing that has fixed it. LGTM, thanks for noticing and fixing the badge issue @mikkelbu

@stevenaw stevenaw merged commit e1f94eb into master Dec 28, 2024
6 checks passed
@mikkelbu mikkelbu deleted the chore/replace-buildstats-info branch December 28, 2024 13:36
@mikkelbu mikkelbu added this to the Release 4.6 milestone Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants