Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define PHP version requirement #21

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Dec 3, 2024

Since version 2.2.0 (c15d225) this package requires at least PHP 8.0. If you install this extension in - for example - Contao 4.13 with PHP 7.4, the follwing error will occur:

PHP Parse error:  syntax error, unexpected ',' in vendor/numero2/contao-proper-filenames/src/Command/CleanFilesCommand.php on   
   line 41 

Now, this PR does not fix that. Even after merging this PR and releasing as 2.2.1, this error will still occur when trying to install this package in Contao 4.13 under PHP 7.4, as version 2.2.0 will still continue to exist with the missing PHP version requirement.

To properly fix it you would actually have to go back to using Annotations instead of PHP Attributes instead. Or you could delete the 2.2.0 version tag (which is not ideal).

On the other hand it's probably not worth properly fixing it anyway. Anyone still running PHP 7.4 just has to put version 2.2.0 as a conflict in their project's composer.json.

@bennyborn bennyborn merged commit 47dc346 into numero2:master Jan 20, 2025
@bennyborn
Copy link
Member

Yeah I guess we're totally fine with just setting PHP 8 as a requirement. Thanks @fritzmg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants