✨(backend) allow to filter member on team access endpoint #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fea999d to
276a385
Compare
mjeammet
reviewed
Apr 29, 2024
src/backend/core/api/viewsets.py
Outdated
Comment on lines
358
to
377
| if query := self.request.GET.get("q", ""): | ||
| similarity = Max( | ||
| TrigramSimilarity( | ||
| Coalesce( | ||
| Func("user__identities__email", function="unaccent"), Value("") | ||
| ), | ||
| Func(Value(query), function="unaccent"), | ||
| ) | ||
| + TrigramSimilarity( | ||
| Coalesce( | ||
| Func("user__identities__name", function="unaccent"), Value("") | ||
| ), | ||
| Func(Value(query), function="unaccent"), | ||
| ) | ||
| ) | ||
| queryset = ( | ||
| queryset.annotate(similarity=similarity) | ||
| .filter(similarity__gte=SIMILARITY_THRESHOLD) | ||
| .order_by("-similarity") | ||
| ) |
There was a problem hiding this comment.
shouldn't it be a little lower, inside the list/retrieve "if" ?
mjeammet
reviewed
Apr 29, 2024
| client.force_login(user) | ||
|
|
||
| response = client.get( | ||
| f"/api/v1.0/teams/{team.id!s}/accesses/?q=BRU", |
There was a problem hiding this comment.
this doesn't work and I'm not sure why 🤔
0a92b13 to
434182b
Compare
9200fa9 to
bbdd4e8
Compare
4620ab1 to
5333e2d
Compare
mjeammet
approved these changes
Jul 31, 2024
6c85e91 to
727118a
Compare
Filter member by name...
727118a to
ab54d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Filter member by main identity name or email.
Proposal
Description...