Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect xml report path from project.yml #21

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Detect xml report path from project.yml #21

merged 1 commit into from
Jun 5, 2019

Conversation

danebou
Copy link

@danebou danebou commented Jun 4, 2019 •
edited
Loading

ThrowTheSwitch/Ceedling#324 Allowed for configuring the report filename path.

This scans the project.yml for that configuration and uses it as the xml report path, otherwise defaults to report.xml as before.

@danebou
Copy link
Author

danebou commented Jun 4, 2019 •
edited
Loading

Oh, looks like there was an issue opened up for this just recently. This should fix it: #20

(It still requires the unreleased Ceedling version though)

@numaru numaru self-requested a review June 5, 2019 18:27
numaru
numaru approved these changes Jun 5, 2019
View reviewed changes
Copy link
Owner

@numaru numaru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you again for contributing 😉

@numaru numaru changed the base branch from master to develop June 5, 2019 18:42
@numaru numaru merged commit 5eb5036 into numaru:develop Jun 5, 2019
@danebou danebou deleted the configurable-report-path branch June 5, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numaru numaru numaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danebou @numaru