Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial gRPC #3

Merged
merged 47 commits into from
Aug 26, 2022
Merged

Initial gRPC #3

merged 47 commits into from
Aug 26, 2022

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Aug 24, 2022

No description provided.

jyu6 added 30 commits August 24, 2022 10:42
add hack package for code generation
cbe954c 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add Makefile for generate proto code
cf72a7e 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add pkg stucture and proto files
413e70e 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
rename function svc name
eac10ad 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
copy current types to the new file
0c93d1f 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update key type from []byte to string
44d94ff 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update example
3a43f31 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update interface
360f349 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update proto
32b27f9 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add options definition
58d7e71 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add initial service
85c8a1b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add TODO comment
1afbaef 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add uds
236dffc 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update example
9d11bdb 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add one todo
8af3b92 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
log with close conn err
4ca13d5 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add mockgen for udfunction
b24adf2 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
rename handle option
820eaae 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add isready for client pkg
7b8b6fa 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
export client
3ae1186 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update isReady logic
2578d5a 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update IsReady logic
118ab6b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update mock gen
40ca037 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add opts for func sdk client
78199cd 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update client mock option
2cb65d5 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update mock gen
e05d949 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update service datum value
03b8a16 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
remove timeout ctx
5e12fa3 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
remove client example code: the user only need to use the server sdk
480a82f 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update git ignore
6c85a6b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@jy4096 jy4096 requested a review from vigith August 24, 2022 17:54
whynowy
whynowy reviewed Aug 24, 2022
View reviewed changes
jyu6 added 2 commits August 24, 2022 12:00
update based on pr reviews
93908ff 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add comments and documents
435e59b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
vigith
vigith reviewed Aug 24, 2022
View reviewed changes
jy4096 and others added 2 commits August 24, 2022 15:59
@jy4096 @vigith
Update pkg/function/service.go
4f9ccfa 
Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update func sdk client option implementation
b5bd0fd 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
add func sdk server options
3f63c2b 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
jyu6 added 6 commits August 25, 2022 08:57
fix clean up logic in server.go
0f15c92 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update git ignore
6ef7e3e 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
delete placeholder function/options.go
e1d8b7d 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update sdk client logic and tests
c73ab63 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
update logic for testing
345ffda 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
refactor test file
f24a2b6 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
create tmp sock for testing
0e59ce5 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@jy4096 jy4096 requested a review from vigith August 26, 2022 19:59
jyu6 added 2 commits August 26, 2022 14:38
fix test sock
57a5c46 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
rename test sock
7dc79c1 
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@vigith vigith merged commit dc42bf6 into main Aug 26, 2022
@vigith vigith deleted the grpc branch August 26, 2022 21:41
ashwinidulams pushed a commit to ashwinidulams/numaflow-go that referenced this pull request Mar 6, 2023
@whynowy
ci: image release action (numaproj#3)
7938a03 
* chore: ci to relase images

Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jy4096 @vigith @whynowy