feature: udsink gRPC #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 14, 2022 17:18
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
jy4096
commented
Sep 16, 2022
pkg/sink/types.go
Outdated
| // In short: | ||
| // Add EventTime and Watermark in the Message type | ||
| // or | ||
| // Delete event_time and watermark in the sink proto file. |
There was a problem hiding this comment.
Please check this TODO
There was a problem hiding this comment.
I feel like we only need Datum...
Message type is only used in the numaflow project. We can replace sinksdk.Message with sinkpb.Datum.
There was a problem hiding this comment.
removed message type..
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
added 4 commits
September 16, 2022 09:33
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
added 2 commits
September 16, 2022 13:29
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
whynowy
reviewed
Sep 16, 2022
added 2 commits
September 16, 2022 14:38
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
vigith
approved these changes
Sep 17, 2022
ashwinidulams
pushed a commit
to ashwinidulams/numaflow-go
that referenced
this pull request
Mar 6, 2023
* ci: fix kafka e2e test Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support udsink gRPC
Tested using the
pkg/sink/examples/udsink_log.goexample