Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test dependency issues using random seeding #91

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Jan 31, 2023

Changes in this PR:

  • Add choma for repeatable, randomized test ordering
  • Make mocked event updaters idempotent
  • Ensure all environment updates happen in a beforeEach() or an it() block
  • Ensure all describe() blocks containing environment updates start with helpers.saveEnvironment()
  • Fix corrupted blocks in api-token.test.js that had a bunch of test code running outside of it() blocks
  • Use a stack for saving/restoring the environment instead of a single variable (to support nested describes)

@mbklein mbklein temporarily deployed to test January 31, 2023 18:52 — with GitHub Actions Inactive
@mbklein mbklein force-pushed the 3525-random-test-order branch from c33aee2 to 37aab30 Compare January 31, 2023 18:57
@mbklein mbklein temporarily deployed to test January 31, 2023 18:57 — with GitHub Actions Inactive

Verified

This commit was signed with the committer’s verified signature.
mbklein Michael B. Klein
@mbklein mbklein force-pushed the 3525-random-test-order branch from 37aab30 to 68b2f1f Compare January 31, 2023 19:00
@mbklein mbklein temporarily deployed to test January 31, 2023 19:00 — with GitHub Actions Inactive
@mbklein mbklein requested review from kdid and bmquinn January 31, 2023 19:05
Copy link
Contributor

@bmquinn bmquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@mbklein mbklein merged commit c8d83bd into deploy/staging Jan 31, 2023
@mbklein mbklein deleted the 3525-random-test-order branch January 31, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants