Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't serialize anonymous tokens #56

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Don't serialize anonymous tokens #56

merged 1 commit into from
Dec 14, 2022

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Dec 14, 2022

  • Immediately expire invalid/expired tokens
  • Let ApiToken class decide when to update (i.e., move event._userTokenUpdated logic into the ApiToken class)

@mbklein mbklein requested a review from kdid December 14, 2022 20:06
@mbklein
Don't serialize anonymous tokens
6605225 
Immediately expire invalid/expired tokens
Let ApiToken class decide when to update
@mbklein mbklein force-pushed the no-anonymous-token-cookie branch from 660959b to 6605225 Compare December 14, 2022 20:06
@mbklein mbklein temporarily deployed to test December 14, 2022 20:06 — with GitHub Actions Inactive
@kdid kdid merged commit 84f9c36 into deploy/staging Dec 14, 2022
@kdid kdid deleted the no-anonymous-token-cookie branch December 14, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdid kdid Awaiting requested review from kdid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbklein @kdid