Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer experience with sam sync and sam deploy #291

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Mar 6, 2025

Closes #196

@@ -116,36 +98,40 @@ aws stepfunctions create-state-machine --endpoint http://localhost:8083 --defini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember if you said something about this but the "Running the API locally with state machines + lambdas..." instruction starting on line 76 no longer works. I tried changing the name of the template but just got an error. Not sure if that part needs to come out or just be updated.

@kdid
Copy link
Contributor

kdid commented Mar 6, 2025

When I tried a make sync I got this error (I had run make samconfig.kdid.yaml first):

Failed to create/update the stack: dc-api-kdid, An error     
occurred (ValidationError) when calling the CreateStack      
operation: Parameters: [DevTeamNetIds, SecretsPath,          
PyramidBucket] must have values                              
Failed to sync infra. Code sync is paused until              
template/stack is fixed.              

@mbklein mbklein force-pushed the reorganize-stacks branch from bc13eeb to 214c02c Compare March 11, 2025 22:07
@mbklein mbklein force-pushed the reorganize-stacks branch 2 times, most recently from a981ee3 to b3f30ae Compare March 12, 2025 14:17
@mbklein mbklein changed the base branch from deploy/staging to deploy/prototype March 12, 2025 14:21
@kdid
Copy link
Contributor

kdid commented Mar 12, 2025

I'm running through the README instructions.

When I make a file download request after starting with make_step and make state-machine, I'm getting the following. Maybe I'm missing a config? I just pulled tfvars

2025-03-12T15:49:11.079Z	c9e93636-0f87-40d6-8140-ac9770cda440	INFO	[Honeybadger] honeybadger.js is in development mode; the following error report will be sent in production. {
  name: 'TypeError',
  message: "Cannot read properties of undefined (reading 'step_function_endpoint')",
  stack: "TypeError: Cannot read properties of undefined (reading 'step_function_endpoint')\n" +
    '    at processAVDownload (/var/task/handlers/get-file-set-download.js:203:38)\n' +
    '    at /var/task/handlers/get-file-set-download.js:52:20\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' +
    '    at async Runtime.handler (/var/task/handlers/middleware.js:37:18)',

@mbklein
Copy link
Contributor Author

mbklein commented Mar 14, 2025

Please:

  • update the branch (will probably require --force)
  • rm env.json
  • try the AV Download stuff again

Add ability to selectively deploy stacks
Use cfn-lint instead of sam validate

Add DEFAULT_SEARCH_SIZE parameter

Add make features for env.json and samconfig.yaml and update documentation

Fix issues with templates & makefile and update documentation

Fix `start-with-step` to allow av-download stack to run
@mbklein mbklein force-pushed the reorganize-stacks branch from 8013f8f to 3622737 Compare March 20, 2025 22:07
@mbklein mbklein merged commit c9a9b60 into deploy/prototype Mar 20, 2025
3 checks passed
@mbklein mbklein deleted the reorganize-stacks branch March 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy Configs: Single vs. Multiple; TOML vs. YAML
2 participants