Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License field to IIIF Manifest response metadata #151

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

adamjarling
Copy link
Contributor

@adamjarling adamjarling commented Jun 23, 2023

What does this do?

  1. Adds License field to IIIF Manifest response metadata
  2. Updates the Readme with some more explicit examples of how to get up and running

Note in the Readme, the example Workflow for DC / API works for displaying Search Results, but there are still CORS errors viewing an individual Work (based on the setup in the Readme). The actual request to the API endpoint is fine, but the network errors occur when tagging ?as=iiif to the end to pull the Manifest. Not sure why this would be different?

@adamjarling adamjarling self-assigned this Jun 23, 2023
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@adamjarling adamjarling force-pushed the 3835-add-license-field branch from 5c6ac49 to 0c2fa30 Compare June 27, 2023 13:18
@adamjarling adamjarling temporarily deployed to test June 27, 2023 13:18 — with GitHub Actions Inactive
@adamjarling adamjarling merged commit a6bde57 into deploy/staging Jun 27, 2023
@adamjarling adamjarling deleted the 3835-add-license-field branch June 27, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants