Add defensiveness for placeholderCanvas if fileset width OR height are null. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
approved these changes
Jun 22, 2023
| // expect(placeholderCanvas.id).to.eq(`${manifest.items[0].id}/placeholder`); | ||
| // expect(placeholderCanvas.type).to.eq("Canvas"); | ||
| // }); | ||
|
|
There was a problem hiding this comment.
Do we want to leave this for later?
There was a problem hiding this comment.
Nope, don't need it. Good catch. That was where I put things initially but then decided a new describe() altogether,
f267bd9 to
1d9ace9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This work adds two steps of defensiveness to determine writing of the
placeholderCanvasproperty.placeholderCanvasis now excluded IF thefileset.widthORfileset.heightare null.placeholderCanvaswidth and height values will be100if the property is somehow included and but thewidthandheightare falsyThis work should make it so Manifests generated from the API never have null width and heights for
placeholderCanvasand thus render correctly in Clover.