Production dcapi types Github action workflow #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbklein
approved these changes
Mar 14, 2023
| shell: bash | ||
| - working-directory: "${{ env.TMP_DSTDIR }}" | ||
| run: | | ||
| git checkout -b dcapi-${{ steps.vars.outputs.short_sha }} |
There was a problem hiding this comment.
Looks like the output name defined on line 39 was short-sha, not short_sha
Suggested change
| git checkout -b dcapi-${{ steps.vars.outputs.short_sha }} | |
| git checkout -b dcapi-${{ steps.vars.outputs.short-sha }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of workflow
Typescript types for the schemas (Works, Collections, FileSets) are automatically published to the nulib/dcapi-types repo on deploys.
deploy/stagingbranch contains changes to thedocs/docs/spec/data-types.yamlfile, new types are generated and a commit is made to thestagingbranch ofnulib/dcapi. This is intended to be for local testing by NUL devs against the private staging API.mainbranch) contains changes to thedocs/docs/spec/data-types.yamlfile, new types are generated and a PR is opened into themainbranch ofnulib/dcapi-types. Also, an issue is created innulib/repodev_planning_and_docsto review the PR and publish the types package (manually).