Staging PR merge workflow to push commit to nulib/dcapi-types #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbklein
approved these changes
Feb 20, 2023
bmquinn
approved these changes
Feb 20, 2023
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
| git config --global user.name "github-actions[bot]" | ||
| git add . | ||
| git commit -m "nulib/dc-api-v2 commit: $GITHUB_SHA, package.json version: ${{ steps.package-version.outputs.current-version}}" |
There was a problem hiding this comment.
I like this for the commit message!
0922b60 to
99493f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dcapi-typesworkflow I'm envisioning is:dc-api-v2deploy/stagingbranch that contains changes todata-types.yaml, we trigger a commit to thestagingbranch in thenulib/dcapi-typesrepo. If the front end wants to work with what's deployed on staging they can reference the package by branch directly. Since no one else has access to the staging environment, we are not going to publish the package at that point.nulib/dc-api-v2(mainbranch that contains changes todata-types.yaml), that will trigger a PR into thedcapi-typespackage'smainbranch. (From there we will either have the PR auto merge (+ auto publish?), or it will be manually reviewed/merged + published. Haven't totally decided on that yet.)This PR contains only the staging workflow (first part of ☝️)
And what do you know, I found a typo to correct in
data-types.yamlto test the on merge workflow....