Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyword from Manifest metadata. #106

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Feb 8, 2023

What does this do?

This removes keyword from IIIF Manifests by updating the metadata helper in the IIIF response.

@mathewjordan mathewjordan temporarily deployed to test February 8, 2023 19:34 — with GitHub Actions Inactive
@mathewjordan mathewjordan temporarily deployed to test February 8, 2023 21:18 — with GitHub Actions Inactive
@mathewjordan mathewjordan force-pushed the 3563-remove-keyword-manifest branch from a02f592 to 215ead5 Compare February 8, 2023 21:19
@mathewjordan mathewjordan temporarily deployed to test February 8, 2023 21:19 — with GitHub Actions Inactive
Copy link
Contributor

@adamjarling adamjarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

{
label: "Keyword",
value: source.keywords,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove this here? Are regular API (non IIIF) functions using this helper too I wonder?

@mathewjordan mathewjordan merged commit fd59b40 into deploy/staging Feb 8, 2023
@mathewjordan mathewjordan deleted the 3563-remove-keyword-manifest branch February 8, 2023 21:32
kdid pushed a commit that referenced this pull request Feb 9, 2023
Remove keyword from Manifest `metadata`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants