test(nuejs-core): for-tests
#507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to sort my notifications out as I only just saw this when looking manually! Maybe you can DM me on Slack if you need my 👀 ? Will take a look tomorrow 🤙 |
|
Oh, no worries. I changed this to wip, because I still wanted to check some stuff. |
|
Nice. I changed my mind about adding more to this PR, and will merge now, since I made no significant changes after the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexpricedev maybe you can also take a look, if this looks fine to you. I roughly oriented myself on your tests.
I can also split array funcs to n tests, so only one function is tested at a time. Would probably be more deterministic / ensure their functionality.
PS: what do you think about a template
index.htmlfor the manual browser tests and creating the neededindex.htmls withcompilescript todist, next to the compiled components?EDIT: added this
Another edit: I think, the for loops are currently not re-run, if we change content of a nested item. I'm gonna take a look at that tomorrow.
For now making this WIP.
Update: I don't think there's any easy solution to this, so not going to follow this here anymore. maybe in the future.