Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exists object storage logic #2958

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Mar 10, 2025

Description

Previous logic didn't work well for objects in gcs, as it was returning a 404 error response

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (0ad193b) to head (61940a9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2958      +/-   ##
==========================================
+ Coverage   84.01%   84.22%   +0.20%     
==========================================
  Files         487      487              
  Lines       35972    35976       +4     
  Branches    10966    10966              
==========================================
+ Hits        30222    30299      +77     
+ Misses       5224     5153      -71     
+ Partials      526      524       -2     
Flag Coverage Δ
nidx 77.63% <ø> (+0.09%) ⬆️
nucliadb 76.04% <100.00%> (+0.24%) ⬆️
nucliadb-ingest 40.68% <0.00%> (+<0.01%) ⬆️
nucliadb-reader 42.05% <0.00%> (-0.02%) ⬇️
nucliadb-search 45.02% <0.00%> (+<0.01%) ⬆️
nucliadb-standalone 46.18% <0.00%> (+<0.01%) ⬆️
nucliadb-train 44.78% <0.00%> (+<0.01%) ⬆️
nucliadb-writer 46.84% <0.00%> (-0.03%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.27% <ø> (ø)
nucliadb_sdk 93.01% <ø> (ø)
nucliadb_telemetry 86.53% <ø> (ø)
nucliadb_utils 84.89% <100.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lferran lferran merged commit ccd53e6 into main Mar 10, 2025
32 checks passed
@lferran lferran deleted the fix-exists-object-storage-logic branch March 10, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants