Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup producers not initialized #2952

Closed
wants to merge 1 commit into from
Closed

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Mar 7, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (284eae1) to head (7ccd7d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/backups/tasks.py 50.00% 3 Missing ⚠️
nucliadb/src/nucliadb/ingest/service/writer.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2952      +/-   ##
==========================================
- Coverage   83.92%   83.85%   -0.08%     
==========================================
  Files         487      487              
  Lines       35900    35941      +41     
  Branches    10933    10964      +31     
==========================================
+ Hits        30130    30138       +8     
- Misses       5241     5277      +36     
+ Partials      529      526       -3     
Flag Coverage Δ
nidx 77.53% <ø> (-0.22%) ⬇️
nucliadb 75.53% <76.92%> (-0.01%) ⬇️
nucliadb-reader 42.06% <76.92%> (+0.01%) ⬆️
nucliadb-search 44.99% <34.61%> (-0.02%) ⬇️
nucliadb-standalone 46.19% <76.92%> (+0.01%) ⬆️
nucliadb-train 44.79% <76.92%> (+0.01%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.26% <ø> (ø)
nucliadb_sdk 93.01% <ø> (ø)
nucliadb_telemetry 86.53% <ø> (ø)
nucliadb_utils 84.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lferran lferran closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant