Move nucliadb tests to ndbfixtures #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Annotate all tests with deploy_modes("standalone") mark
- Replace nucliadb_manager by nucliadb_reader_manager or nucliadb_writer_manager
- replace nucliadb_grpc by nucliadb_ingest_grpc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 86.89% 86.85% -0.05%
==========================================
Files 382 382
Lines 24161 24161
==========================================
- Hits 20995 20984 -11
- Misses 3166 3177 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Rename widely used knowledgebox fixture to standalone_knowledgebox
javitonino
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea here is to move all nucliadb/tests/nucliadb to ndbfixtures in the least painful way I can find :)
How was this PR tested?
Describe how you tested this PR.